Skip to content

add as_json tag#286

Merged
nateshim merged 1 commit intomainfrom
nateshim/hotfix/generate_test_metadata
Jan 8, 2025
Merged

add as_json tag#286
nateshim merged 1 commit intomainfrom
nateshim/hotfix/generate_test_metadata

Conversation

@nateshim
Copy link
Contributor

@nateshim nateshim commented Jan 8, 2025

Internal Notes for Reviewers

External Release Notes

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Nate Shim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nateshim nateshim added the internal Not to be externalized in the release notes label Jan 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

PR Summary

This pull request introduces an enhancement to the list_tasks_and_tags function in the validmind/tests/load.py file. The function now accepts an optional parameter as_json. When set to True, the function returns the task and tag data as a dictionary instead of a formatted DataFrame. This enhancement allows for more flexible data handling, particularly useful for scenarios where JSON output is preferred or required.

Test Suggestions

  • Test list_tasks_and_tags() with as_json=False to ensure it returns a DataFrame as before.
  • Test list_tasks_and_tags(as_json=True) to verify it returns a dictionary with the correct structure.
  • Test list_tasks_and_tags(as_json=True) with no tasks or tags to ensure it returns an empty dictionary.
  • Test list_tasks_and_tags(as_json=True) with multiple tasks and tags to ensure all are included in the dictionary.

@nateshim nateshim requested a review from cachafla January 8, 2025 19:49
Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nateshim nateshim merged commit 2d7d75e into main Jan 8, 2025
6 of 7 checks passed
@johnwalz97 johnwalz97 deleted the nateshim/hotfix/generate_test_metadata branch February 27, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants